Remove Breez SDK dependency #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 26, 2024
Closed
Closed
erdemyerebasmaz
force-pushed
the
breez-sdk-removal
branch
from
978ed78
to
995e414
Compare
dangeross
reviewed
Jun 26, 2024
| @@ -28,7 +25,7 @@ class CurrencyBloc extends Cubit<CurrencyState> with HydratedMixin { | |||
| } | |||
|
|
|||
| void listFiatCurrencies() { | |||
| _breezSDK.listFiatCurrencies().then((fiatCurrencies) { | |||
| liquidSdk.wallet!.listFiatCurrencies().then((fiatCurrencies) { | |||
There was a problem hiding this comment.
I know this isn't under review (sorry for throwing the 🔧). I think name wallet might become confusing for devs using the SDK, especially when listing fiat rates etc. They might assume its access to the underlying liquid wallet. Something like instance might be better (if it's not a reserved word) liquidSdk.instance!.listFiatCurrencies()
There was a problem hiding this comment.
Sounds good. Let's open an issue for it.
| inputType is InputType_LnUrlWithdraw || | ||
| inputType is InputType_LnUrlAuth || | ||
| inputType is InputType_LnUrlError || | ||
| inputType is InputType_NodeId)) { |
There was a problem hiding this comment.
I think NodeId would also not be supported
There was a problem hiding this comment.
Noted. It'll be removed as part of #30
dangeross
approved these changes
Jun 26, 2024
|
Thanks for the reviews. I'll merge after adding CI requirements. |
erdemyerebasmaz
force-pushed
the
breez-sdk-removal
branch
from
88ec2d1
to
22528b7
Compare
*Shared modules are moved to sdk-common and is now accessible from Liquid SDK. *Update CurrencyBloc to use FiatAPI
closes #22
- Remove setting up Breez SDK steps - Remove choosing a Breez SDK ref for workflow
erdemyerebasmaz
force-pushed
the
breez-sdk-removal
branch
from
22528b7
to
aafea00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
FiatAPImethods to Liquid SDK breez-sdk-liquid#331This PR removes Breez SDK as shared modules are fully moved to
sdk-commonand is now accessible from Liquid SDK.Changelist:
CurrencyBlocto useFiatAPICurrencyConverterDialog